refactor: centralize env access via internal/env package - #27
Merged
Conversation
… CI/CD - Replace all context.TODO() calls in production and test code with context.Background() or proper context propagation - Enable shadow and nilness govet linters; re-enable select staticcheck checks (SA4006, S1011, S1034) - Fix CI coverage threshold comment (50% -> 60%) - Extract markdownlint config to .markdownlint-cli2.jsonc - Pin actions/setup-go to SHA in setup-deps and hawk actions - Change setup-deps default branch from dev to main - Add tracking issue references to all t.Skip() calls
- Create internal/env/env.go with zero-dependency Getenv wrapper - Update config.Getenv to delegate to env.Getenv - Migrate os.Getenv calls across internal/ to env.Getenv or config.Getenv - Update AGENTS.md policy: env.Getenv for simple reads, config.EnvManager for profile/secret management - Add exceptions for runtime probes and telemetry
This commit resolves all 145 golangci-lint issues that surfaced when the shadow, nilness, and additional staticcheck checks were enabled: - 142 shadow (govet): renamed inner shadowed variables to context-specific names (statErr, writeErr, unmarshalErr, etc.) - 22 model/provider shadows: renamed to modelName/providerName - 2 nilness tautologies (non-nil != nil): removed redundant nil checks - 1 staticcheck SA4006 (unused value): removed dead assignment No function signatures, exported types, or behavior changed. No linters were disabled or skipped. .golangci.yml is unchanged. Build and lint pass cleanly. The CI lint check on PR #26 will now pass.
…entralize-env-access
Patel230
added a commit
that referenced
this pull request
Jun 15, 2026
* refactor: replace context.TODO() with context.Background() and harden CI/CD - Replace all context.TODO() calls in production and test code with context.Background() or proper context propagation - Enable shadow and nilness govet linters; re-enable select staticcheck checks (SA4006, S1011, S1034) - Fix CI coverage threshold comment (50% -> 60%) - Extract markdownlint config to .markdownlint-cli2.jsonc - Pin actions/setup-go to SHA in setup-deps and hawk actions - Change setup-deps default branch from dev to main - Add tracking issue references to all t.Skip() calls * refactor: centralize env access via internal/env package - Create internal/env/env.go with zero-dependency Getenv wrapper - Update config.Getenv to delegate to env.Getenv - Migrate os.Getenv calls across internal/ to env.Getenv or config.Getenv - Update AGENTS.md policy: env.Getenv for simple reads, config.EnvManager for profile/secret management - Add exceptions for runtime probes and telemetry * fix: resolve 145 golangci-lint shadow and nilness issues This commit resolves all 145 golangci-lint issues that surfaced when the shadow, nilness, and additional staticcheck checks were enabled: - 142 shadow (govet): renamed inner shadowed variables to context-specific names (statErr, writeErr, unmarshalErr, etc.) - 22 model/provider shadows: renamed to modelName/providerName - 2 nilness tautologies (non-nil != nil): removed redundant nil checks - 1 staticcheck SA4006 (unused value): removed dead assignment No function signatures, exported types, or behavior changed. No linters were disabled or skipped. .golangci.yml is unchanged. Build and lint pass cleanly. The CI lint check on PR #26 will now pass.
Patel230
added a commit
that referenced
this pull request
Jun 18, 2026
* refactor: replace context.TODO() with context.Background() and harden CI/CD - Replace all context.TODO() calls in production and test code with context.Background() or proper context propagation - Enable shadow and nilness govet linters; re-enable select staticcheck checks (SA4006, S1011, S1034) - Fix CI coverage threshold comment (50% -> 60%) - Extract markdownlint config to .markdownlint-cli2.jsonc - Pin actions/setup-go to SHA in setup-deps and hawk actions - Change setup-deps default branch from dev to main - Add tracking issue references to all t.Skip() calls * refactor: centralize env access via internal/env package - Create internal/env/env.go with zero-dependency Getenv wrapper - Update config.Getenv to delegate to env.Getenv - Migrate os.Getenv calls across internal/ to env.Getenv or config.Getenv - Update AGENTS.md policy: env.Getenv for simple reads, config.EnvManager for profile/secret management - Add exceptions for runtime probes and telemetry * fix: resolve 145 golangci-lint shadow and nilness issues This commit resolves all 145 golangci-lint issues that surfaced when the shadow, nilness, and additional staticcheck checks were enabled: - 142 shadow (govet): renamed inner shadowed variables to context-specific names (statErr, writeErr, unmarshalErr, etc.) - 22 model/provider shadows: renamed to modelName/providerName - 2 nilness tautologies (non-nil != nil): removed redundant nil checks - 1 staticcheck SA4006 (unused value): removed dead assignment No function signatures, exported types, or behavior changed. No linters were disabled or skipped. .golangci.yml is unchanged. Build and lint pass cleanly. The CI lint check on PR #26 will now pass.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
internal/env/env.gowith zero-dependencyGetenvwrapper importable by allinternal/packages without cycle riskconfig.Getenvnow delegates toenv.Getenvto avoid forcing all callers through the heavyweightinternal/configpackageos.Getenvcalls acrossinternal/to useenv.Getenvorconfig.Getenv(whichever is cycle-safe)env.Getenvfor simple reads,config.EnvManagerfor profile/secret managementTMUX,STY,TERM_PROGRAM,SHELL,GOPATH,HOME) and telemetry env varsFiles Changed
internal/env/env.go— zero-dependency wrapper aroundos.Getenvinternal/config/envmanager.go—config.Getenvdelegates toenv.Getenvinternal/autoinit/autoinit.go—os.Getenv→config.Getenvinternal/auth/auth.go—os.Getenv("HOME")→ portablehomeDir()helperinternal/tool/safety.go—os.Getenv("HAWK_CONFIG_DIR")→env.Getenvinternal/tool/web_search_brave.go—os.Getenv("BRAVE_SEARCH_API_KEY")→env.Getenvinternal/tool/web_search_searxng.go—os.Getenv("SEARXNG_URL")→env.Getenvinternal/resilience/health/diagnostics.go—os.Getenv("HAWK_MODEL")→config.GetenvAGENTS.md— anti-pattern updated to reflectenv.Getenvand document exceptionsWhy a separate
internal/envpackage?internal/configimportsinternal/tool, which meansinternal/toolcannot importinternal/configwithout creating a cycle. A tinyinternal/envpackage with zero hawk-internal dependencies resolves this.Verification
go build ./...✅go vet ./...✅go test ./internal/{env,autoinit,auth,tool,resilience/health}/✅TestFormatDeveloperPathReport_ContainsSectionsflake (macOS keychain prompt) is unrelated to these changes